You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/17 13:05:36 UTC
[GitHub] [ignite] sk0x50 opened a new pull request, #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
sk0x50 opened a new pull request, #10201:
URL: https://github.com/apache/ignite/pull/10201
… outside the disco-notifier-worker
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sk0x50 commented on a diff in pull request #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
Posted by GitBox <gi...@apache.org>.
sk0x50 commented on code in PR #10201:
URL: https://github.com/apache/ignite/pull/10201#discussion_r948757469
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsFullMessage.java:
##########
@@ -178,6 +178,21 @@ public GridDhtPartitionsFullMessage(@Nullable GridDhtPartitionExchangeId id,
GridDhtPartitionsFullMessage cp = (GridDhtPartitionsFullMessage)msg;
cp.parts = parts;
+ if (parts != null) {
+ cp.parts = new HashMap<>(parts.size());
+
+ for (Map.Entry<Integer, GridDhtPartitionFullMap> e : parts.entrySet()) {
+ GridDhtPartitionFullMap val = e.getValue();
+
+ cp.parts.put(e.getKey(), new GridDhtPartitionFullMap(
+ val.nodeId(),
+ val.nodeOrder(),
+ val.updateSequence(),
+ val,
+ false));
+ }
+ }
+
Review Comment:
Yes, I will fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
Posted by GitBox <gi...@apache.org>.
ivandasch commented on code in PR #10201:
URL: https://github.com/apache/ignite/pull/10201#discussion_r948334253
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsFullMessage.java:
##########
@@ -178,6 +178,21 @@ public GridDhtPartitionsFullMessage(@Nullable GridDhtPartitionExchangeId id,
GridDhtPartitionsFullMessage cp = (GridDhtPartitionsFullMessage)msg;
cp.parts = parts;
+ if (parts != null) {
+ cp.parts = new HashMap<>(parts.size());
+
+ for (Map.Entry<Integer, GridDhtPartitionFullMap> e : parts.entrySet()) {
+ GridDhtPartitionFullMap val = e.getValue();
+
+ cp.parts.put(e.getKey(), new GridDhtPartitionFullMap(
+ val.nodeId(),
+ val.nodeOrder(),
+ val.updateSequence(),
+ val,
+ false));
+ }
+ }
+
Review Comment:
May be add here
```
}
else
cp.parts = null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sk0x50 closed pull request #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
Posted by GitBox <gi...@apache.org>.
sk0x50 closed pull request #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
URL: https://github.com/apache/ignite/pull/10201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10201: IGNITE-17542 Fixed an issue with modifying CacheAffinityChangeMessage…
Posted by GitBox <gi...@apache.org>.
ivandasch commented on code in PR #10201:
URL: https://github.com/apache/ignite/pull/10201#discussion_r948334741
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsFullMessage.java:
##########
@@ -178,6 +178,21 @@ public GridDhtPartitionsFullMessage(@Nullable GridDhtPartitionExchangeId id,
GridDhtPartitionsFullMessage cp = (GridDhtPartitionsFullMessage)msg;
cp.parts = parts;
+ if (parts != null) {
+ cp.parts = new HashMap<>(parts.size());
+
+ for (Map.Entry<Integer, GridDhtPartitionFullMap> e : parts.entrySet()) {
+ GridDhtPartitionFullMap val = e.getValue();
+
+ cp.parts.put(e.getKey(), new GridDhtPartitionFullMap(
+ val.nodeId(),
+ val.nodeOrder(),
+ val.updateSequence(),
+ val,
+ false));
+ }
+ }
+
Review Comment:
Or just skip this at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org