You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "masc2008 (via GitHub)" <gi...@apache.org> on 2026/08/02 02:02:53 UTC

[PR] net: Fix fragment forwarding and IPv6 reassembly keys [nuttx]

masc2008 opened a new pull request, #19597:
URL: https://github.com/apache/nuttx/pull/19597

   ## Summary
   - suppress ICMP errors for IPv4 non-initial fragments during forwarding failures
   - include IPv6 source/destination addresses in fragment reassembly matching
   
   ## Testing
   - git diff --check HEAD~2..HEAD
   - tools/nxstyle net/ipforward/ipv4_forward.c
   - tools/nxstyle net/ipfrag/ipfrag.c
   - tools/nxstyle net/ipfrag/ipfrag.h
   - tools/nxstyle net/ipfrag/ipv6_frag.c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] net: Fix fragment forwarding and IPv6 reassembly keys [nuttx]

Posted by "masc2008 (via GitHub)" <gi...@apache.org>.
masc2008 closed pull request #19597: net: Fix fragment forwarding and IPv6 reassembly keys
URL: https://github.com/apache/nuttx/pull/19597


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] net: Fix fragment forwarding and IPv6 reassembly keys [nuttx]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19597:
URL: https://github.com/apache/nuttx/pull/19597#issuecomment-5154598752

   <!-- membrowse-pr-comment -->
   ## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report
   
   *No memory changes detected for:*
   - [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [qemu-armv8a](https://membrowse.com/public/apache/nuttx/target/qemu-armv8a/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   - [stm32-nucleo-f103rb](https://membrowse.com/public/apache/nuttx/target/stm32-nucleo-f103rb/compare?head=b1b788812dac071ea0c1f83a31d9f7f4e42d3e2e&base=9aa6eb56715bcd41311b3386f4b5124f5657b92a)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] net: Fix fragment forwarding and IPv6 reassembly keys [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #19597:
URL: https://github.com/apache/nuttx/pull/19597#discussion_r3699603989


##########
net/ipfrag/ipfrag.c:
##########
@@ -575,9 +607,13 @@ bool ip_fragin_enqueue(FAR struct net_driver_s *dev,
     {
       node = (struct ip_fragsnode_s *)entry;
 
-      if (dev == node->dev && curfraglink->ipid <= node->ipid)
+      if (dev == node->dev)

Review Comment:
   why need this check which is already done in ip_fragin_match



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org