You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/29 00:55:31 UTC
[GitHub] [iceberg] bartash opened a new issue, #5882: Allow SnapshotManager to be created using an existing iceberg transaction
bartash opened a new issue, #5882:
URL: https://github.com/apache/iceberg/issues/5882
### Apache Iceberg version
main (development)
### Query engine
_No response_
### Please describe the bug 🐞
SnapshotManager creates its own iceberg transaction which is private. This prevents clients from adding anything to the transaction. An example use case where this is desirable is that some catalog users use additional HMS properties to include version numbers for cache invalidation. It is desirable that these HMS properties are updated as part of the same iceberg transaction used by SnapshotManager.
One fix would be to allow SnapshotManager to be created from Transaction in a similar way that an ExpireSnapshots object can be created by Transaction.expireSnapshots(). An alternative fix would be to add a constructor to SnapshotManager that takes an iceberg transaction Object as a parameter. For convenience an overload of BaseTable.manageSnapshots() would also be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] gaborkaszab commented on issue #5882: Allow SnapshotManager to be created using an existing iceberg transaction
Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on issue #5882:
URL: https://github.com/apache/iceberg/issues/5882#issuecomment-1262396599
Let me take a look, @bartash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] gaborkaszab commented on issue #5882: Allow SnapshotManager to be created using an existing iceberg transaction
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on issue #5882:
URL: https://github.com/apache/iceberg/issues/5882#issuecomment-1488056139
Merged by #6074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] commented on issue #5882: Allow SnapshotManager to be created using an existing iceberg transaction
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5882:
URL: https://github.com/apache/iceberg/issues/5882#issuecomment-1487767835
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] gaborkaszab closed issue #5882: Allow SnapshotManager to be created using an existing iceberg transaction
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab closed issue #5882: Allow SnapshotManager to be created using an existing iceberg transaction
URL: https://github.com/apache/iceberg/issues/5882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org