[jira] [Commented] (FLINK-6522) Add ZooKeeper cleanup logic to ZooKeeperHaServices

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071314#comment-16071314 ] 

ASF GitHub Bot commented on FLINK-6522:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4204#discussion_r125164937
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/filesystem/FileSystemStateStorageHelper.java ---
    @@ -77,4 +83,18 @@ public FileSystemStateStorageHelper(Path rootPath, String prefix) throws IOExcep
     	private Path getNewFilePath() {
     		return new Path(rootPath, FileUtils.getRandomFilename(prefix));
     	}
    +
    +	@Override
    +	public void closeAndCleanupAllData() {
    +		try {
    +			fs.delete(rootPath, true);
    +		} catch (Exception e) {
    +			LOG.error("Failed to clean up state storage directory.", e);
    --- End diff --
    
    I would not catch this exception


> Add ZooKeeper cleanup logic to ZooKeeperHaServices
> --------------------------------------------------
>
>                 Key: FLINK-6522
>                 URL: https://issues.apache.org/jira/browse/FLINK-6522
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>
> The {{ZooKeeperHaServices}} provide a {{CuratorFramework}} client to access ZooKeeper data. Consequently, all data (also for different job) are stored under the same root node. When {{HighAvailabilityServices#closeAndCleanupAllData}} is called, then this data should be cleaned up. This cleanup logic is currently missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)