You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/08 09:23:45 UTC

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2765: [IOTDB-1180]Optimize log file name

jixuan1989 commented on a change in pull request #2765:
URL: https://github.com/apache/iotdb/pull/2765#discussion_r589275789



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -25,14 +25,12 @@
     <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
     <appender class="ch.qos.logback.core.rolling.RollingFileAppender" name="FILEERROR">
         <file>${IOTDB_HOME}/logs/log_error.log</file>
-        <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
-            <fileNamePattern>${IOTDB_HOME}/logs/log-error.%i.log.gz</fileNamePattern>
-            <minIndex>1</minIndex>
-            <maxIndex>5</maxIndex>
+        <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">

Review comment:
       is there any upper bound for each file? and the total size of files?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org