You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/09/09 04:15:17 UTC
Review Request 74107: UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74107/
-----------------------------------------------------------
Review request for atlas and Prasad Pawar.
Bugs: ATLAS-4660
https://issues.apache.org/jira/browse/ATLAS-4660
Repository: atlas
Description
-------
Create a business metadata with an attribute such that it has a space in its name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). Create at least two more attributes for the business metadata.
Go to the entity details page for that entity with these business metadata attributes and assign values to the above attributes.
After the page refreshes, pick that attribute with the space with its name and delete its value.
You will notice that on clicking the delete button for the first time, nothing happens. When the delete button is clicked again,then all of the other assigned values are wiped out along with the targeted attribute.
Diffs
-----
dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js ff285068d
dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 913cc0faf
Diff: https://reviews.apache.org/r/74107/diff/1/
Testing
-------
Tested manually on both the UI's for the above mentioned scenario.
Thanks,
Farhan Khan
Re: Review Request 74107: UI: Deleting businesss metadata attribute values with spaces in their key names results in unexpected behaviour.
Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74107/#review224658
-----------------------------------------------------------
Ship it!
Ship It!
- Prasad Pawar
On Sept. 9, 2022, 4:15 a.m., Farhan Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74107/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2022, 4:15 a.m.)
>
>
> Review request for atlas and Prasad Pawar.
>
>
> Bugs: ATLAS-4660
> https://issues.apache.org/jira/browse/ATLAS-4660
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create a business metadata with an attribute such that it has a space in its name. (eg: 'testBusinessMetadata' with attribute 'test attribute1'). Create at least two more attributes for the business metadata.
> Go to the entity details page for that entity with these business metadata attributes and assign values to the above attributes.
> After the page refreshes, pick that attribute with the space with its name and delete its value.
> You will notice that on clicking the delete button for the first time, nothing happens. When the delete button is clicked again,then all of the other assigned values are wiped out along with the targeted attribute.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js ff285068d
> dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 913cc0faf
>
>
> Diff: https://reviews.apache.org/r/74107/diff/1/
>
>
> Testing
> -------
>
> Tested manually on both the UI's for the above mentioned scenario.
>
>
> Thanks,
>
> Farhan Khan
>
>