You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/01 18:55:22 UTC
[GitHub] [tinkerpop] simonz-bq opened a new pull request, #1674: Bump logback version to 1.2.9 or greater
simonz-bq opened a new pull request, #1674:
URL: https://github.com/apache/tinkerpop/pull/1674
Fixes https://issues.apache.org/jira/browse/TINKERPOP-2746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1150231817
VOTE+1 I will merge this through sometime today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto merged pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
lyndonbauto merged PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1145178082
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1674](https://codecov.io/gh/apache/tinkerpop/pull/1674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1393f20) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/f94e203a7b010052373446be7c247b678f317de0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f94e203) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #1674 +/- ##
========================================
Coverage 63.84% 63.84%
========================================
Files 23 23
Lines 3596 3596
========================================
Hits 2296 2296
Misses 1137 1137
Partials 163 163
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1674?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1674?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f94e203...1393f20](https://codecov.io/gh/apache/tinkerpop/pull/1674?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
simonz-bq commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1144209875
> logback version is defined in the root pom.xml in `<dependencyManagement>`:
>
> https://github.com/apache/tinkerpop/blob/master/pom.xml#L822-L826
>
> as a result, i don't think you need to add the `<version>` to all the pom.xml individually.
The Tinkerpop pom.xml is complex so I can't say with certainty if it's necessary.
My thought process is that if you build using the main pom.xml, then the dependency will be grabbed based on the version specified, and therefore satisfies the dependency requirement of the individual pom.xml when those dependencies are resolved.
However, if someone were to modularly use the individual maven projects as a standalone, I had a concern that then the dependency would not enforce a non-vulnerable versioning, hence why I added it.
If someone can confirm that this is not an issue, then I think removing the added `<version`> to the individual pom is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1144220418
you can remove it. the point of `<dependencyManagement>` is to centralize dependency definitions so you don't need to repeat yourself throughout the sub-modules. you should be able to prove it to yourself by doing a `mvn dependency:tree -pl <sub-module>` and check the logback version you find there.
> if someone were to modularly use the individual maven projects as a standalone
just fyi, they would have to make a lot of changes to the a sub-project pom to get it to work in this fashion, so i would hope they would just skip trying to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1144166986
logback version is defined in the root pom.xml in `<dependencyManagement>`:
https://github.com/apache/tinkerpop/blob/master/pom.xml#L822-L826
as a result, i don't think you need to add the `<version>` to all the pom.xml individually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1674: Bump logback version to 1.2.9 or greater
Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1674:
URL: https://github.com/apache/tinkerpop/pull/1674#issuecomment-1147708278
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org