[GitHub] [pinot] jadami10 commented on pull request #9443: Fix the bug of hybrid table request using the same request id

[GitBox <gi...@apache.org>]

jadami10 commented on PR #9443:
URL: https://github.com/apache/pinot/pull/9443#issuecomment-1289328378

   Is there a reason we needed to do it this way (negative ids)? Most log search technologies folks use will expect KV filter like `requestId=123`. This will by default filter out `requestId=-123` which I think is a pretty big regression. Why not add a new dimension to the log like `tableType`. That way folks know whether this was the realtime/offline side, we filter in by default, and now you can filter/stratify by offline/realtime as needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org