You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/02/10 07:29:42 UTC
[GitHub] [wicket] helmut8080 opened a new pull request #403: Iteration stops
with nested containers
helmut8080 opened a new pull request #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403
Since there is only one pop() performed in hasNext() the iteration stops, if there are several nested container, when there are no additional childs in the parent container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g commented on issue #403: Iteration stops with
nested containers
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403#issuecomment-596169026
https://issues.apache.org/jira/browse/WICKET-6754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] helmut8080 commented on issue #403: Iteration stops with
nested containers
Posted by GitBox <gi...@apache.org>.
helmut8080 commented on issue #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403#issuecomment-586646881
Sure. Hope its ok to just post the unit test here:
@Test
void streamChildrenNestedContainer() {
WebMarkupContainer wmc = new WebMarkupContainer("parent");
WebMarkupContainer wmc1 = new WebMarkupContainer("wmc1");
wmc.add(wmc1);
WebMarkupContainer wmc1_2= new WebMarkupContainer("wmc1_2");
wmc1.add(wmc1_2);
Label lbl2 = new Label("lbl2");
wmc.add(lbl2);
List<String> l = wmc.streamChildren().map(t -> t.getId()).collect(Collectors.toList());
// System.out.println(l);
assertEquals(l.toString(), "[wmc1, wmc1_2, lbl2]");
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g commented on issue #403: Iteration stops with
nested containers
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403#issuecomment-583999357
Thank you for the Pull request, @helmut8080 !
Can you add a unit test demonstrating the problem ? It will help preventing a regression in the future.
A quickstart application is also good. We will convert it to a test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g merged pull request #403: Iteration stops with
nested containers
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g commented on issue #403: Iteration stops with
nested containers
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #403: Iteration stops with nested containers
URL: https://github.com/apache/wicket/pull/403#issuecomment-596170183
Thank you, @helmut8080 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services