You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 08:48:34 UTC

[GitHub] [arrow-datafusion] mingmwang commented on issue #4389: Proposal: Improve the join keys of logical plan

mingmwang commented on issue #4389:
URL: https://github.com/apache/arrow-datafusion/issues/4389#issuecomment-1331820602

   > 😭, I also confused about we split the join to `join` and `crossjoin` in the logical phase, I think we can combine these two together and just add `crossjoin` join_type for this. This is a historical issue and don't know when the datafusion add the `cross join` in the logical plan.
   > 
   > I think it's necessary to refactor this to combine them together in the logical phase, but it will bring a `api break changes` in the `logical.proto`.
   > 
   > @andygrove @alamb @Dandandan
   
   I would prefer to keep the current two logical joins, `join` and `crossjoin`, but change the equal join conditions `Vec<(column,column)> `  to an `Option`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org