You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2019/12/19 20:31:00 UTC

[jira] [Assigned] (SPARK-30309) Mark `Filter` as a `sealed` class

     [ https://issues.apache.org/jira/browse/SPARK-30309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun reassigned SPARK-30309:
-------------------------------------

    Assignee: Maxim Gekk

> Mark `Filter` as a `sealed` class
> ---------------------------------
>
>                 Key: SPARK-30309
>                 URL: https://issues.apache.org/jira/browse/SPARK-30309
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Maxim Gekk
>            Assignee: Maxim Gekk
>            Priority: Trivial
>
> Add the `sealed` keyword to the `Filter` class at the `org.apache.spark.sql.sources` package. So, the compiler should output a warning if handling of a filter is missed in a datasource:
> {code}
> Warning:(154, 65) match may not be exhaustive.
> It would fail on the following inputs: AlwaysFalse(), AlwaysTrue()
>     def translate(filter: sources.Filter): Option[Expression] = filter match {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org