You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/07 09:58:46 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #15014: fix: consistent dataset list
zhaoyongjie opened a new pull request #15014:
URL: https://github.com/apache/superset/pull/15014
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
closes: https://github.com/apache/superset/issues/14262
Currently, between the `Dataset list view` and `change dataset modal` datasets order is inconsistent. The `change dataset modal` can not display all datasets.
This PR make
1. `Dataset list view` and `change dataset modal` datasets order is consistent
2. make server pagination in `change dataset modal`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### Before
<img width="1471" alt="image" src="https://user-images.githubusercontent.com/2016594/120994394-044c8b80-c7b7-11eb-9558-e19d7d8d425a.png">
#### After
Consistent dataset list between `dataset list` and `Change dataset modal`
<img width="1473" alt="image" src="https://user-images.githubusercontent.com/2016594/120994651-44ac0980-c7b7-11eb-9f20-8450d362d9d7.png">
https://user-images.githubusercontent.com/2016594/120997286-a66d7300-c7b9-11eb-8210-04bec81a4db9.mp4
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/14262
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-858080859
Got it, let's address it in a separate PR. ๐ข
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856916263
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-857006249
@zhaoyongjie thanks for addressing the issues! Pagination is 'fixed' and Sort works mostly as expected! ๐
only thing I'm not sure is the cap F goes to the top of the list.
I spot checked pagination in other areas, list view, data south table, they all look good!
https://user-images.githubusercontent.com/67837651/121239710-6efcd600-c84e-11eb-899d-4c4d76b5ae9d.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856739217
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856181704
๐thanks for the PR.
1. after the PR, sorting no longer work~ :( please make sure when we add new feature, the old related behavior is preserved.
2. not related to this PR, please have pagination fixed at the bottom on scroll.
https://user-images.githubusercontent.com/67837651/121073555-802edf80-c787-11eb-9697-a8a2e95c8573.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856376773
@junlincc
1. The frontend sorting seems that not work previous. the after screenshot is on the master branch.
<img width="896" alt="image" src="https://user-images.githubusercontent.com/2016594/121109602-7e742300-c83e-11eb-8088-3755b7256c82.png">
2. the pagination flowing, I will fix it in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856376773
@junlincc
1. The frontend sorting seems that not work previous. the after screenshot is on the master branch. let me try to fix it.
<img width="896" alt="image" src="https://user-images.githubusercontent.com/2016594/121109602-7e742300-c83e-11eb-8088-3755b7256c82.png">
2. the pagination flowing, I will fix it in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856159751
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856160778
@junlincc Ephemeral environment spinning up at http://54.245.30.41:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-858224750
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-857312281
> @zhaoyongjie thanks for addressing the issues! Pagination is 'fixed' and Sort works mostly as expected! ๐
> only thing I'm not sure is the cap F goes to the top of the list.
> I spot checked pagination in other areas, list view, data south table, they all look good!
> Screen.Recording.2021-06-08.at.11.38.44.AM.mov
Due to server sorting, it's order is ASCII order. refer to:
https://support.ecisolutions.com/doc-ddms/help/reportsmenu/ascii_sort_order_chart.htm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856883470
# [Codecov](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15014](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (544731c) into [master](https://codecov.io/gh/apache/superset/commit/0e07a5ca03cb2a6f560b77847c13413b9a8c7d97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e07a5c) will **increase** coverage by `0.00%`.
> The diff coverage is `82.85%`.
[](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15014 +/- ##
=======================================
Coverage 77.64% 77.64%
=======================================
Files 966 967 +1
Lines 49615 49643 +28
Branches 6311 6324 +13
=======================================
+ Hits 38524 38547 +23
- Misses 10890 10895 +5
Partials 201 201
```
| Flag | Coverage ฮ | |
|---|---|---|
| javascript | `72.79% <82.85%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage ฮ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `87.35% <76.47%> (-3.56%)` | :arrow_down: |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `96.96% <81.81%> (-1.25%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.18% <100.00%> (-0.37%)` | :arrow_down: |
| [...-frontend/src/views/CRUD/data/dataset/constants.ts](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L2NvbnN0YW50cy50cw==) | `100.00% <100.00%> (รธ)` | |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <0.00%> (รธ)` | |
| [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `98.50% <0.00%> (+0.06%)` | :arrow_up: |
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `91.02% <0.00%> (+0.11%)` | :arrow_up: |
| [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/15014/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `87.50% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `ฮ = absolute <relative> (impact)`, `รธ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0e07a5c...544731c](https://codecov.io/gh/apache/superset/pull/15014?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856742612
@zhaoyongjie Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-857312281
> @zhaoyongjie thanks for addressing the issues! Pagination is 'fixed' and Sort works mostly as expected! ๐
> only thing I'm not sure is the cap F goes to the top of the list.
> I spot checked pagination in other areas, list view, data south table, they all look good!
> Screen.Recording.2021-06-08.at.11.38.44.AM.mov
Due to server sorting, it's order is ASCII order. refer to:
- https://support.ecisolutions.com/doc-ddms/help/reportsmenu/ascii_sort_order_chart.htm
- https://en.wikipedia.org/wiki/ASCII#Character_order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #15014:
URL: https://github.com/apache/superset/pull/15014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-858080859
Got it, let's address it in a separate PR. ๐ข
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15014: fix(datasets): consistent dataset list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15014:
URL: https://github.com/apache/superset/pull/15014#issuecomment-856927907
@junlincc Ephemeral environment spinning up at http://52.34.217.130:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org