You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/05 07:37:55 UTC
[GitHub] [incubator-nuttx] bkueng opened a new pull request #212: fix
stm32_spibus_initialize: add missing leave_critical_section
bkueng opened a new pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section
URL: https://github.com/apache/incubator-nuttx/pull/212
in case the requested SPI bus is invalid or not configured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] bkueng commented on a change in pull request
#212: fix stm32_spibus_initialize: add missing leave_critical_section
Posted by GitBox <gi...@apache.org>.
bkueng commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section
URL: https://github.com/apache/incubator-nuttx/pull/212#discussion_r375668479
##########
File path: arch/arm/src/stm32f7/stm32_spi.c
##########
@@ -2177,6 +2177,7 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
else
#endif
{
+ leave_critical_section(flags);
Review comment:
Good point. I updated accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#212: fix stm32_spibus_initialize: add missing leave_critical_section
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section
URL: https://github.com/apache/incubator-nuttx/pull/212#discussion_r375488989
##########
File path: arch/arm/src/stm32f7/stm32_spi.c
##########
@@ -2177,6 +2177,7 @@ FAR struct spi_dev_s *stm32_spibus_initialize(int bus)
else
#endif
{
+ leave_critical_section(flags);
Review comment:
@bkueng Why not just delete the return NULL? As FAR struct stm32_spidev_s *priv = NULL; if unassigned but a port.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 merged pull request #212: fix
stm32_spibus_initialize: add missing leave_critical_section
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #212: fix stm32_spibus_initialize: add missing leave_critical_section
URL: https://github.com/apache/incubator-nuttx/pull/212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services