[GitHub] [flink] bowenli86 commented on issue #10575: [FLINK-15234] hive table created from flink catalog table shouldn't have null properties in parameters

[GitBox <gi...@apache.org>]

bowenli86 commented on issue #10575: [FLINK-15234] hive table created from flink catalog table shouldn't have null properties in parameters
URL: https://github.com/apache/flink/pull/10575#issuecomment-565631320
 
 
   > PR looks good. Just a couple of minor points:
   > 
   > 1. Can you change the JIRA title, cannot=>shouldn't
   > 2. Create a negative test case covering the case if property map has a null valued key.
   >    Thanks.
   
   Thanks @xuefuz ! I updated the jira title.
   
   For negative test case, as we have set the strict check in AbstractCatalogTable for null-valued properties and also fixed the 'comment' bug, the only negative case I can think of is to use Hive's metastore client to send a test catalog table impl which contains null-value, but it doesn't seems add much value to us. What negative case are you thinking of?
   
   I'll merge this PR first to unblock community from testing hivecatalog. Will add negative cases later if you have any in mind

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services