[GitHub] [pinot] zhtaoxiang commented on pull request #8959: Update minion task metadata ZNode path

[GitBox <gi...@apache.org>]

zhtaoxiang commented on PR #8959:
URL: https://github.com/apache/pinot/pull/8959#issuecomment-1165041300

   > Ideally, we want to automatically move the ZNRecord from the old path to the new path. When reading the ZK metadata, if we find the old path exist:
   > 
   > 1. If the new one also exist, remove the old one
   > 2. If the new one does not exist, copy the old record to the new path, then remove the old one
   
   We can do 1 safely. 
   However, 2 is not easy, since the copy-remove operation needs to be atomic. Otherwise, we cannot guarantee that the old and the new ZNodes hold the same data, so we will never know when it's safe to remove the old ZKNode.
   
   I'd prefer we keep the current logic and discuss how to implement the proposal correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org