[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1436: IGNITE-18087 Populate DistributionZoneManager with CMG listeners to logical topology events

[GitBox <gi...@apache.org>]

sanpwc commented on code in PR #1436:
URL: https://github.com/apache/ignite-3/pull/1436#discussion_r1050501543


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -74,21 +82,45 @@ public class DistributionZoneManager implements IgniteComponent {
     /** Busy lock to stop synchronously. */
     private final IgniteSpinBusyLock busyLock = new IgniteSpinBusyLock();
 
+    /** Logical topology service to track topology changes. */
+    private final LogicalTopologyService logicalTopologyService;
+
+    /** Listener for a topology events. */
+    private final LogicalTopologyEventListener topologyEventListener = new LogicalTopologyEventListener() {
+        @Override
+        public void onAppeared(ClusterNode appearedNode, LogicalTopologySnapshot newTopology) {
+            updateMetaStorageKeys(newTopology, false);

Review Comment:
   Confusing naming, I'd rather use updateLogicalTopologyInMetaStorage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org