[jira] [Commented] (ARIES-1134) Enable JPA 2.1 API and correct inconsistent versioning

["Timothy Ward (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820281#comment-13820281 ] 

Timothy Ward commented on ARIES-1134:
-------------------------------------

I would like to formally -1 this commit

The Aries JPA container and JPA container context are providers of the JPA API. It is incorrect for them to use a consumer version range.

It is also incorrect to increase the version range without also adding support to both JPA container and JPA container context for those APIs. There needs to be more switching logic added inside those bundles to cope with the different versions of the API they support. The JPA container is currently broken in that it claims JPA 2.1 support without providing it. I note that there are no tests for this, and I would expect them to fail when someone tries to call a new method like EntityManager#createEntityGraph(String) or EntityManagerFactory#addNamedQuery(String, Query).

It may be worth considering removing support for JPA 1.0 if it is deemed too difficult to support three versions of the JPA API at once. We may also wish to try using the new Java Contracts defined by the OSGi alliance.

In any event this commit needs to be reverted, as the correct version ranges for the container and container context bundles will be [x,2.2).

Regards,

Tim

> Enable JPA 2.1 API and correct inconsistent <aries.osgi.import> versioning
> --------------------------------------------------------------------------
>
>                 Key: ARIES-1134
>                 URL: https://issues.apache.org/jira/browse/ARIES-1134
>             Project: Aries
>          Issue Type: Improvement
>          Components: Blueprint, JPA
>            Reporter: Albert Lee
>            Priority: Minor
>         Attachments: ARIES-1134.patch
>
>
> There are some inconsistency of <aries.osgi.import> version useage between these modules:
> jpa/jpa-api/pom.xml
> jpa/jpa-container/pom.xml
> jpa/jpa-container-context/pom.xml
> jpa/jpa-container-eclipselink-adapter/pom.xml
>             javax.persistence;version="[1.0.0,2.1.0)",
>             javax.persistence.spi;version="[1.0.0,2.1.0)",
>             javax.persistence.criteria;version="[1.1.0,2.1.0)";
>             javax.persistence.metamodel;version="[1.1.0,2.1.0)";
> and 
> jpa-blueprint-aries/pom.xml
>             javax.persistence;version="[1.0.0,3.0.0)",
> I would like to propose all these modules' version updated to 
>             javax.persistence;version="[1.0.0,3.0.0)",
> so the JPA 2.1 API can be used at runtime, if enabled by the container environment.



--
This message was sent by Atlassian JIRA
(v6.1#6144)