You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/05/15 17:25:12 UTC
[kudu-CR] [server] remove unused JWT-related flags
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19891
Change subject: [server] remove unused JWT-related flags
......................................................................
[server] remove unused JWT-related flags
As it turns out, the following JWT flags aren't used in the code at all:
* --jwks_discovery_endpoint_base
* --jwt_allow_without_tls
* --jwt_validate_signature
This patches removes the definitions of the flags and their usage
in a few tests.
Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
2 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/19891/1
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 May 2023 04:26:51 +0000
Gerrit-HasComments: No
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [server] remove unused JWT-related flags
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
Patch Set 2:
Thank you for review, Yingchun!
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 May 2023 05:13:09 +0000
Gerrit-HasComments: No
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
Patch Set 1: Verified+1
unrelated test failures (flakiness):
* CatalogManagerTskITest.LeadershipChangeOnTskGeneration
* LogRollingITest.TestLogCleanupOnStartup
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 19:22:59 +0000
Gerrit-HasComments: No
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 17:26:06 +0000
Gerrit-HasComments: No
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
[server] remove unused JWT-related flags
As it turns out, the following JWT flags aren't used in the code at all:
* --jwks_discovery_endpoint_base
* --jwt_allow_without_tls
* --jwt_validate_signature
This patches removes the definitions of the flags and their usage
in a few tests.
Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Reviewed-on: http://gerrit.cloudera.org:8080/19891
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
2 files changed, 0 insertions(+), 19 deletions(-)
Approvals:
Alexey Serbin: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 )
Change subject: [server] remove unused JWT-related flags
......................................................................
Patch Set 2: Verified+1
unrelated test failures (flakiness):
* TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/1
* AutoRebalancerTest.NextLeaderResumesAutoRebalancing
* LogRollingITest.TestLogCleanupOnStartup
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 May 2023 02:13:30 +0000
Gerrit-HasComments: No
[kudu-CR] [server] remove unused JWT-related flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [server] remove unused JWT-related flags
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib8e688b7c89e24cb5e91f6b6cc89b7ae984b4c35
Gerrit-Change-Number: 19891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>