You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/21 18:24:20 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #12471: Fix/treemap emphasis
100pah opened a new pull request #12471:
URL: https://github.com/apache/incubator-echarts/pull/12471
1. Enable treemap emphasis label formatter. Fix #11854. And add test cases.
[Details]:
The implementation of "insert levelModel" is migrate from "Tree.getModel"
to "beforeLink nodeData.wrapMethod('getItemModel', ...)", because the former
one miss the case of `data.getItemModel`, which is needed in label formatter fetcher.
2. Fix the incorrect implementation of `leavesModel` in `TreeSeries`.
This defect is found when fix "1". "1" and "2" are sharing the same data structure (Tree, insert model) so we'd better fix them together.
[Details]:
`leavesModel` should be inserted between the node `itemModel` and the `seriesModel` in the "parentModel" chain.
It can be added either via [A] "beforeLink - nodeData.wrapMethod('getItemModel, ...)"
or via [B] "TreeNode.getModel ".
But `TreeSeres` both use the two strategy, which causes the `leavesModel` is inserted twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12471: Fix/treemap emphasis
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12471:
URL: https://github.com/apache/incubator-echarts/pull/12471#issuecomment-617621129
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org