You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vivek807 (via GitHub)" <gi...@apache.org> on 2023/11/12 18:56:18 UTC
[PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
vivek807 opened a new pull request, #15363:
URL: https://github.com/apache/druid/pull/15363
Fixes #14454 .
### Description
Patched security vulnerability by updating Ranger libraries to the newest available version.
#### Release note
This change removes the log4j dependency from the extension. It is done by updating Ranger libraries to the newest available version. The functioning of this library does not change.
<hr>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "maytasm (via GitHub)" <gi...@apache.org>.
maytasm commented on PR #15363:
URL: https://github.com/apache/druid/pull/15363#issuecomment-2073608350
@LakshSingla @abhishekagarwal87 I see the 29.0.0 release notes mentioned this PR but I don't think this PR is actually in v29?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "vivek807 (via GitHub)" <gi...@apache.org>.
vivek807 commented on PR #15363:
URL: https://github.com/apache/druid/pull/15363#issuecomment-1823533081
> thank you for your first contribution @vivek807
Thanks @abhishekagarwal87 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #15363:
URL: https://github.com/apache/druid/pull/15363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "vivek807 (via GitHub)" <gi...@apache.org>.
vivek807 commented on code in PR #15363:
URL: https://github.com/apache/druid/pull/15363#discussion_r1392902225
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -185,7 +431,7 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.compile.version}</version>
- <scope>runtime</scope>
+ <scope>test</scope>
Review Comment:
Done
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -211,6 +457,47 @@
</usedDependencies>
</configuration>
</plugin>
+ <plugin>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "vivek807 (via GitHub)" <gi...@apache.org>.
vivek807 commented on code in PR #15363:
URL: https://github.com/apache/druid/pull/15363#discussion_r1392874687
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -170,10 +184,242 @@
</dependencies>
<profiles>
<profile>
- <id>hadoop3</id>
+ <id>hadoop2</id>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "BartMiki (via GitHub)" <gi...@apache.org>.
BartMiki commented on code in PR #15363:
URL: https://github.com/apache/druid/pull/15363#discussion_r1390820772
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -170,10 +184,242 @@
</dependencies>
<profiles>
<profile>
- <id>hadoop3</id>
+ <id>hadoop2</id>
Review Comment:
Drop that, Hadoop 2 is deprecated and should not be part of this extension
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -211,6 +457,47 @@
</usedDependencies>
</configuration>
</plugin>
+ <plugin>
Review Comment:
Remove the build plugin, it was needed to build the extension separately from Druid, it will be built as part of Druid now
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -185,7 +431,7 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.compile.version}</version>
- <scope>runtime</scope>
+ <scope>test</scope>
Review Comment:
Don't change the scope
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -34,6 +34,10 @@
<relativePath>../../pom.xml</relativePath>
</parent>
+ <properties>
Review Comment:
You should change that in the master pom.xml of Druid, not here, it should be removed from here
##########
extensions-core/druid-ranger-security/src/assembly/assembly.xml:
##########
Review Comment:
Remove this whole file, it was for building extension separately from Druid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Patched security vulnerability by updating Ranger libraries to the ne… (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #15363:
URL: https://github.com/apache/druid/pull/15363#issuecomment-1822481139
thank you for your first contribution @vivek807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org