You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/01/18 23:38:24 UTC
[kudu-CR] docs: update docs for metadata dir
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9068
Change subject: docs: update docs for metadata dir
......................................................................
docs: update docs for metadata dir
Commit 64926335fe263b43f1493c03a91ea999759dfc71 introduced the
fs_metadata_dir flag. Given the significance of this flag, the docs have
been updated accordingly.
I didn't document the behavior from Kudu 1.6 and below, as the important
details are already noted in the flag definition.
Rendered versions here:
https://github.com/andrwng/kudu/blob/metadata-docs/docs/administration.adoc#disk_failure_recovery
https://github.com/andrwng/kudu/blob/metadata-docs/docs/configuration.adoc#directory_configuration
Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 25 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/9068/1
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: update docs for metadata dir
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 18:51:39 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for metadata dir
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9068
to look at the new patch set (#2).
Change subject: docs: update docs for metadata dir
......................................................................
docs: update docs for metadata dir
Commit 64926335fe263b43f1493c03a91ea999759dfc71 introduced the
fs_metadata_dir flag. Given the significance of this flag, the docs have
been updated accordingly.
I didn't document the behavior from Kudu 1.6 and below, as the important
details are already noted in the flag definition.
Rendered versions here:
https://github.com/andrwng/kudu/blob/metadata-docs/docs/administration.adoc#disk_failure_recovery
https://github.com/andrwng/kudu/blob/metadata-docs/docs/configuration.adoc#directory_configuration
Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 24 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/9068/2
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: update docs for metadata dir
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc@66
PS1, Line 66: drives (i.e. with high bandwidth
: and low latency, e.g. solid-state drives)
drives with high bandwidth and low latency, e.g. solid-state drives.
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc@72
PS1, Line 72: multiple
multiple values
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 18 Jan 2018 23:54:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update docs for metadata dir
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 01:24:48 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for metadata dir
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 01:29:21 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for metadata dir
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 00:20:58 +0000
Gerrit-HasComments: No
Re: [kudu-CR] docs: update docs for metadata dir
Posted by Alexandra Rodoni <ar...@cloudera.com>.
Which version of Kudu is this doc for? 1.6? Earlier? Later?
On Fri, Jan 19, 2018 at 5:15 PM, Andrew Wong (Code Review) <
gerrit@cloudera.org> wrote:
> Andrew Wong *merged* this change.
>
> View Change <http://gerrit.cloudera.org:8080/9068>
> Approvals: Andrew Wong: Verified Alex Rodoni: Looks good to me, but
> someone else must approve Adar Dembo: Looks good to me, approved
>
> docs: update docs for metadata dir
>
> Commit 64926335fe263b43f1493c03a91ea999759dfc71 introduced the
> fs_metadata_dir flag. Given the significance of this flag, the docs have
> been updated accordingly.
>
> I didn't document the behavior from Kudu 1.6 and below, as the important
> details are already noted in the flag definition.
>
> Rendered versions here:
> https://github.com/andrwng/kudu/blob/metadata-docs/docs/administration.adoc#disk_failure_recovery
> https://github.com/andrwng/kudu/blob/metadata-docs/docs/configuration.adoc#directory_configuration
>
> Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
> Reviewed-on: http://gerrit.cloudera.org:8080/9068
> Tested-by: Andrew Wong <aw...@cloudera.com>
> Reviewed-by: Alex Rodoni <ar...@cloudera.com>
> Reviewed-by: Adar Dembo <ad...@cloudera.com>
> ---
> M docs/administration.adoc
> M docs/configuration.adoc
> 2 files changed, 24 insertions(+), 14 deletions(-)
>
> To view, visit change 9068 <http://gerrit.cloudera.org:8080/9068>. To
> unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
> Gerrit-Project: kudu
> Gerrit-Branch: master
> Gerrit-MessageType: merged
> Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
> Gerrit-Change-Number: 9068
> Gerrit-PatchSet: 3
> Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
> Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
> Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
> Gerrit-Reviewer: Kudu Jenkins
>
[kudu-CR] docs: update docs for metadata dir
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
docs: update docs for metadata dir
Commit 64926335fe263b43f1493c03a91ea999759dfc71 introduced the
fs_metadata_dir flag. Given the significance of this flag, the docs have
been updated accordingly.
I didn't document the behavior from Kudu 1.6 and below, as the important
details are already noted in the flag definition.
Rendered versions here:
https://github.com/andrwng/kudu/blob/metadata-docs/docs/administration.adoc#disk_failure_recovery
https://github.com/andrwng/kudu/blob/metadata-docs/docs/configuration.adoc#directory_configuration
Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Reviewed-on: http://gerrit.cloudera.org:8080/9068
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/administration.adoc
M docs/configuration.adoc
2 files changed, 24 insertions(+), 14 deletions(-)
Approvals:
Andrew Wong: Verified
Alex Rodoni: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: update docs for metadata dir
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9068 )
Change subject: docs: update docs for metadata dir
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc
File docs/configuration.adoc:
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc@66
PS1, Line 66: drives with high bandwidth and low
: latency, e.g. solid-state drives. If `--f
> drives with high bandwidth and low latency, e.g. solid-state drives.
Done
http://gerrit.cloudera.org:8080/#/c/9068/1/docs/configuration.adoc@72
PS1, Line 72: not spe
> multiple values
Done
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 19 Jan 2018 00:39:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update docs for metadata dir
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: docs: update docs for metadata dir
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I333d32080106cd83b92ad2060f3239b9c44d201b
Gerrit-Change-Number: 9068
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins