You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/05/07 09:27:40 UTC

[PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

gnodet opened a new pull request, #23037:
URL: https://github.com/apache/camel/pull/23037

   [CAMEL-23431](https://issues.apache.org/jira/browse/CAMEL-23431)
   
   Migrate `camel-grpc` and `camel-mllp` tests from `AvailablePortFinder` to port-0 `ServerSocket` binding, eliminating TOCTOU race conditions that can cause flaky `BindException` failures.
   
   ## Changes
   
   ### camel-grpc
   - Add `getLocalPort()` to `GrpcConsumer` to expose the OS-assigned port after server start
   - Change port validation from `> 0` to `>= 0` to allow port 0 (OS-assigned)
   - Migrate all 14 test files to use port 0 and read back the actual port
   
   ### camel-mllp
   - Add `getLocalPort()` to `MllpTcpServerConsumer` to expose the OS-assigned port
   - Migrate 6 test files to use port 0 and read back the actual port
   
   ## Test plan
   - [ ] CI passes for camel-grpc tests
   - [ ] CI passes for camel-mllp tests
   - [ ] No regressions in other modules


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23037:
URL: https://github.com/apache/camel/pull/23037#issuecomment-4395877843

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #23037:
URL: https://github.com/apache/camel/pull/23037#issuecomment-4411830986

   @gnodet can you update this PR as it has merge conflicts now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #23037:
URL: https://github.com/apache/camel/pull/23037#issuecomment-4508801924

   > Jobs are failing with: `System.IO.IOException: No space left on device` on different attempt so it means that it is really this build which is either exceeding capacity because too many tests are triggered or this PR introduced a leak of file writing (low probability)
   
   Yeah, I know.  A log file is being filled with stack traces in a tight loop, so it quickly fills up disk space.  I need to investigate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #23037:
URL: https://github.com/apache/camel/pull/23037#issuecomment-4496317216

   Jobs are failing with: `System.IO.IOException: No space left on device` on different attempt so it means that it is really this build which is either exceeding capacity because too many tests are triggered or this PR introduced a leak of file writing (low probability)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23037:
URL: https://github.com/apache/camel/pull/23037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23431: Migrate camel-grpc and camel-mllp tests from AvailablePortFinder to port-0 binding [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23037:
URL: https://github.com/apache/camel/pull/23037#issuecomment-4556008695

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-grpc`
   - `components/camel-mllp`
   
   :white_check_mark: **POM dependency changes: targeted tests included**
   
   <details><summary>Modules affected by dependency changes (2)</summary>
   
   - `:camel-grpc`
   - `:camel-mllp`
   
   </details>
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `components/camel-mllp`: 1 test(s) disabled on GitHub Actions
   
   <details><summary>All tested modules (9 modules)</summary>
   
   - Camel :: JBang :: MCP
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: TUI
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Launcher :: Container
   - Camel :: MLLP
   - Camel :: YAML DSL :: Validator
   - Camel :: YAML DSL :: Validator Maven Plugin
   - Camel :: gRPC
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26517983829)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org