You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/04/22 08:37:52 UTC
[GitHub] [arrow] mapleFU opened a new pull request, #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
mapleFU opened a new pull request, #35283:
URL: https://github.com/apache/arrow/pull/35283
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Auto enable brotli when enable fuzzing
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Detect Fuzzing enabled, if it's, enable BROTLI
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1523048507
Benchmark runs are scheduled for baseline = 797f3460c15d11f3e5b12da1809644e53fd910b5 and contender = 8fbf2d732789c9ae6f296fed6559078c96270bd5. 8fbf2d732789c9ae6f296fed6559078c96270bd5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1e81ca3905b04a89a2f049ac4b887f62...2d9c56b1d5e94c7ca0e489c1c5c4b9db/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ca89580d75d84717827f14708d1d4f24...ee2cc4fd24ad415286cba018b886bcd7/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/36c7d484401d44b799fdc503d1dfdb58...99b9a362f6d54e11b90103e0a14f1b3d/)
[Finished :arrow_down:0.48% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f9b9ce0eaa6f4a5fa6ec7c79842392dd...c7bed90c6bab4866b63aea2443307925/)
Buildkite builds:
[Finished] [`8fbf2d73` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2782)
[Failed] [`8fbf2d73` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2816)
[Finished] [`8fbf2d73` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2780)
[Finished] [`8fbf2d73` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2807)
[Finished] [`797f3460` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2781)
[Failed] [`797f3460` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2815)
[Finished] [`797f3460` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2779)
[Finished] [`797f3460` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2806)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1521623622
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on a diff in pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #35283:
URL: https://github.com/apache/arrow/pull/35283#discussion_r1176789856
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -264,7 +264,8 @@ takes precedence over ccache if a storage backend is configured" ON)
"Build Arrow Fuzzing executables"
OFF
DEPENDS
- ARROW_TESTING)
+ ARROW_TESTING
+ ARROW_WITH_BROTLI)
Review Comment:
Meaning: the CI scripts might need to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35283:
URL: https://github.com/apache/arrow/pull/35283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on a diff in pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #35283:
URL: https://github.com/apache/arrow/pull/35283#discussion_r1176785833
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -264,7 +264,8 @@ takes precedence over ccache if a storage backend is configured" ON)
"Build Arrow Fuzzing executables"
OFF
DEPENDS
- ARROW_TESTING)
+ ARROW_TESTING
+ ARROW_WITH_BROTLI)
Review Comment:
This is nice, but it means build scripts will error out when options don't satisfy these dependencies, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1522594905
The Python failures will be fixed by #35324.
I think that the R failure is unrelated but I re-ran the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1521724639
Ooops... CI Boomed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1518562447
:warning: GitHub issue #35282 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1518562434
* Closes: #35282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1521314569
@wjones127 @kou Would you mind take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1522677233
The R failure is happen on main too: https://github.com/apache/arrow/actions/runs/4803502649/jobs/8548049946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35283:
URL: https://github.com/apache/arrow/pull/35283#issuecomment-1521474859
Could you do this in `cpp/cmake_modules/DefineOptions.cmake`?
```diff
diff --git a/cpp/cmake_modules/DefineOptions.cmake b/cpp/cmake_modules/DefineOptions.cmake
index bbbcbe7eb..a4f7a7871 100644
--- a/cpp/cmake_modules/DefineOptions.cmake
+++ b/cpp/cmake_modules/DefineOptions.cmake
@@ -264,7 +264,8 @@ takes precedence over ccache if a storage backend is configured" ON)
"Build Arrow Fuzzing executables"
OFF
DEPENDS
- ARROW_TESTING)
+ ARROW_TESTING
+ ARROW_WITH_BROTOLI)
define_option(ARROW_LARGE_MEMORY_TESTS "Enable unit tests which use large memory" OFF)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35283: GH-35282: [C++] auto enable brotli when enable fuzzing
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35283:
URL: https://github.com/apache/arrow/pull/35283#discussion_r1177011522
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -264,7 +264,8 @@ takes precedence over ccache if a storage backend is configured" ON)
"Build Arrow Fuzzing executables"
OFF
DEPENDS
- ARROW_TESTING)
+ ARROW_TESTING
+ ARROW_WITH_BROTLI)
Review Comment:
It's not right.
It means that "-DARROW_WITH_BROTLI=ON is added implicitly when -DARROW_FUZZING=ON is specified".
We don't need to update the CI scripts .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org