You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/20 13:16:47 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5637: [HUDI-4124] Add valid check in Spark Datasource configs

xushiyan commented on code in PR #5637:
URL: https://github.com/apache/hudi/pull/5637#discussion_r878133161


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -57,7 +64,11 @@ public class HoodieIndexConfig extends HoodieConfig {
 
   public static final ConfigProperty<String> INDEX_TYPE = ConfigProperty
       .key("hoodie.index.type")
-      .noDefaultValue()
+      .defaultValue(BLOOM.name())

Review Comment:
   can we make it `SIMPLE` here? we switched to SIMPLE default here https://github.com/apache/hudi/pull/4659



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org