You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/04 03:32:37 UTC
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15650
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
ranger: allow overwriting of the log4j2 properties file
It seems important for users to have the ability to have subsequent runs
of the master honor any new logging configurations specified via gflag.
As such, it seems important to allow users to regenerate the log4j2
properties file used by the Ranger client, even if one exists.
This patch enables this by introducing the --ranger_overwrite_log_config
gflag, which is set to true by default.
Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 109 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15650/1
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc@371
PS2, Line 371: &matches));
> How about using Env::Glob for this and the regexp stuff?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 04 Apr 2020 21:45:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15650
to look at the new patch set (#2).
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
ranger: allow overwriting of the log4j2 properties file
It seems important for users to have the ability to have subsequent runs
of the master honor any new logging configurations specified via gflag.
As such, it seems important to allow users to recreate the log4j2
properties file used by the Ranger client, even if one exists.
This patch enables this by introducing the --ranger_overwrite_log_config
gflag, which is set to true by default.
Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 109 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15650/2
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
ranger: allow overwriting of the log4j2 properties file
It seems important for users to have the ability to have subsequent runs
of the master honor any new logging configurations specified via gflag.
As such, it seems important to allow users to recreate the log4j2
properties file used by the Ranger client, even if one exists.
This patch enables this by introducing the --ranger_overwrite_log_config
gflag, which is set to true by default.
Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Reviewed-on: http://gerrit.cloudera.org:8080/15650
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 132 insertions(+), 31 deletions(-)
Approvals:
Andrew Wong: Verified
Alexey Serbin: Looks good to me, approved
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc@308
PS2, Line 308: RETURN_NOT_OK(WriteStringToFileSync(
: env, subprocess::Log4j2Properties(program_name, FLAGS_log_dir, log_filename,
: FLAGS_max_log_size, FLAGS_max_log_files,
: FLAGS_ranger_log_level,
: FLAGS_ranger_logtostdout),
: log4j2_properties_file));
Is it possible that the existing file is read by some actor while being overwritten? If so, maybe replace the file atomically using the temporary file with subsequent move/rename approach?
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 05 Apr 2020 03:13:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15650
to look at the new patch set (#4).
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
ranger: allow overwriting of the log4j2 properties file
It seems important for users to have the ability to have subsequent runs
of the master honor any new logging configurations specified via gflag.
As such, it seems important to allow users to recreate the log4j2
properties file used by the Ranger client, even if one exists.
This patch enables this by introducing the --ranger_overwrite_log_config
gflag, which is set to true by default.
Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 132 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15650/4
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 06 Apr 2020 06:27:21 +0000
Gerrit-HasComments: No
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc@308
PS2, Line 308: // don't read a partial file (not expected, but just in case).
: unique_ptr<WritableFile> tmp_file;
: string tmp_path;
: RETURN_NOT_OK(env->NewTempWritableFile(WritableFileOptions(),
: Substitute("$0.XXXXXX", log4j2_properties_path),
:
> Is it possible that the existing file is read by some actor while being ove
It's possible, though not expected. Done
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 06 Apr 2020 03:04:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 4: Verified+1
Unrelated flake:
BadTabletCopyITest.TestBadCopy
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 06 Apr 2020 03:49:04 +0000
Gerrit-HasComments: No
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 04 Apr 2020 22:08:31 +0000
Gerrit-HasComments: No
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:
http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client-test.cc@371
PS2, Line 371: RETURN_NOT_OK(ListFilesInDir(env, dir, &files));
How about using Env::Glob for this and the regexp stuff?
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 04 Apr 2020 21:10:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 06 Apr 2020 05:44:06 +0000
Gerrit-HasComments: No
[kudu-CR] ranger: allow overwriting of the log4j2 properties file
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15650
to look at the new patch set (#3).
Change subject: ranger: allow overwriting of the log4j2 properties file
......................................................................
ranger: allow overwriting of the log4j2 properties file
It seems important for users to have the ability to have subsequent runs
of the master honor any new logging configurations specified via gflag.
As such, it seems important to allow users to recreate the log4j2
properties file used by the Ranger client, even if one exists.
This patch enables this by introducing the --ranger_overwrite_log_config
gflag, which is set to true by default.
Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
2 files changed, 93 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15650/3
--
To view, visit http://gerrit.cloudera.org:8080/15650
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa
Gerrit-Change-Number: 15650
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)