You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Cliff Jansen <cl...@gmail.com> on 2014/02/04 09:41:14 UTC

Re: Review Request 17521: ssl-cert-name connection argument processing in AMQP 1.0.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17521/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 8:41 a.m.)


Review request for qpid.


Changes
-------

Changed as suggested.


Bugs: QPID-5524
    https://issues.apache.org/jira/browse/QPID-5524


Repository: qpid


Description
-------

Same logic as the 0-10 client once the connection option is located.


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h 1564226 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1564226 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp 1564226 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/TransportContext.h 1564226 

Diff: https://reviews.apache.org/r/17521/diff/


Testing
-------

Linux.


Thanks,

Cliff Jansen

Re: Review Request 17521: ssl-cert-name connection argument processing in AMQP 1.0.

Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17521/#review33574
-----------------------------------------------------------

Ship it!


Looks good, thanks for fixing this Cliff!


http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp
<https://reviews.apache.org/r/17521/#comment63108>

    qpid/messaging/ConnectionOptions.h would be nicer, but I'm really picking nits there :-)


- Gordon Sim


On Feb. 4, 2014, 8:41 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17521/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 8:41 a.m.)
> 
> 
> Review request for qpid.
> 
> 
> Bugs: QPID-5524
>     https://issues.apache.org/jira/browse/QPID-5524
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Same logic as the 0-10 client once the connection option is located.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h 1564226 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1564226 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp 1564226 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/TransportContext.h 1564226 
> 
> Diff: https://reviews.apache.org/r/17521/diff/
> 
> 
> Testing
> -------
> 
> Linux.
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>