You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/24 03:17:18 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request #12670: Add scaling distSQL:[STOP SCALING SOURCE WRITING jobId] & [SHOW SCALING CHECK ALGORITHMS]
RaigorJiang opened a new pull request #12670:
URL: https://github.com/apache/shardingsphere/pull/12670
Add scaling distSQL:
- STOP SCALING SOURCE WRITING jobId
- SHOW SCALING CHECK ALGORITHMS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #12670: Add scaling distSQL:[STOP SCALING SOURCE WRITING jobId] & [SHOW SCALING CHECK ALGORITHMS]
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #12670:
URL: https://github.com/apache/shardingsphere/pull/12670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12670: Add scaling distSQL:[STOP SCALING SOURCE WRITING jobId] & [SHOW SCALING CHECK ALGORITHMS]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12670:
URL: https://github.com/apache/shardingsphere/pull/12670#issuecomment-926363337
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12670](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17eaa20) into [master](https://codecov.io/gh/apache/shardingsphere/commit/481ae884928b67d69a928cde0a1dbe8318b52205?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (481ae88) will **increase** coverage by `0.05%`.
> The diff coverage is `36.17%`.
> :exclamation: Current head 17eaa20 differs from pull request most recent head 38f21fa. Consider uploading reports for the commit 38f21fa to get more accurate results
[](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12670 +/- ##
============================================
+ Coverage 63.42% 63.48% +0.05%
- Complexity 1336 1346 +10
============================================
Files 2444 2456 +12
Lines 37139 37237 +98
Branches 6414 6414
============================================
+ Hits 23557 23641 +84
- Misses 11682 11690 +8
- Partials 1900 1906 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dler/ShowScalingCheckAlgorithmsQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZGlzdHNxbC9oYW5kbGVyL1Nob3dTY2FsaW5nQ2hlY2tBbGdvcml0aG1zUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...stsql/handler/StopScalingSourceWritingUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZGlzdHNxbC9oYW5kbGVyL1N0b3BTY2FsaW5nU291cmNlV3JpdGluZ1VwZGF0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...istsql/parser/core/ScalingSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9jb3JlL1NjYWxpbmdTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ery/ShowScalingCheckAlgorithmsStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9xdWVyeS9TaG93U2NhbGluZ0NoZWNrQWxnb3JpdGhtc1N0YXRlbWVudEFzc2VydC5qYXZh) | `40.00% <40.00%> (ø)` | |
| [.../distsql/ral/impl/QueryableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9RdWVyeWFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `80.00% <50.00%> (+13.33%)` | :arrow_up: |
| [.../distsql/ral/impl/UpdatableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9VcGRhdGFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `66.66% <50.00%> (+66.66%)` | :arrow_up: |
| [...pdate/StopScalingSourceWritingStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC91cGRhdGUvU3RvcFNjYWxpbmdTb3VyY2VXcml0aW5nU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `54.54% <54.54%> (ø)` | |
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vU1FMUGFyc2VyVGVzdENhc2VzLmphdmE=) | `99.64% <100.00%> (+<0.01%)` | :arrow_up: |
| [...g/ShowScalingCheckAlgorithmsStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2Rpc3RzcWwvcmFsL3NjYWxpbmcvU2hvd1NjYWxpbmdDaGVja0FsZ29yaXRobXNTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ing/StopScalingSourceWritingStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2Rpc3RzcWwvcmFsL3NjYWxpbmcvU3RvcFNjYWxpbmdTb3VyY2VXcml0aW5nU3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/shardingsphere/pull/12670/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [481ae88...38f21fa](https://codecov.io/gh/apache/shardingsphere/pull/12670?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #12670: Add scaling distSQL:[STOP SCALING SOURCE WRITING jobId] & [SHOW SCALING CHECK ALGORITHMS]
Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #12670:
URL: https://github.com/apache/shardingsphere/pull/12670#issuecomment-926379553
Verification, they all works.
```
mysql> SHOW SCALING CHECK ALGORITHMS;
+---------+---------------------------------------------------+--------------------------+----------------+
| type | description | supported_database_types | provider |
+---------+---------------------------------------------------+--------------------------+----------------+
| DEFAULT | Default implementation with CRC32 of all records. | ["MySQL","PostgreSQL"] | ShardingSphere |
+---------+---------------------------------------------------+--------------------------+----------------+
1 row in set (0.13 sec)
mysql> STOP SCALING SOURCE WRITING 1;
Query OK, 0 rows affected (0.07 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org