You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 05:20:45 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #23189: Add alias to SQL hint keys.

RaigorJiang opened a new pull request, #23189:
URL: https://github.com/apache/shardingsphere/pull/23189

   Ref #21226
   
   Add alias to SQL hint keys, in order to maintain some backward compatibility
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #23189: Add alias to SQL hint keys.

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23189:
URL: https://github.com/apache/shardingsphere/pull/23189


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #23189: Add alias to SQL hint keys.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23189:
URL: https://github.com/apache/shardingsphere/pull/23189#issuecomment-1367740012

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23189](https://codecov.io/gh/apache/shardingsphere/pull/23189?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f801c43) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d719c4e74a79bde49141a796c693cf1af8360b4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d719c4e) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #23189   +/-   ##
   =========================================
     Coverage     49.79%   49.80%           
     Complexity     2442     2442           
   =========================================
     Files          4013     4014    +1     
     Lines         57386    57397   +11     
     Branches       9105     9110    +5     
   =========================================
   + Hits          28575    28585   +10     
     Misses        26273    26273           
   - Partials       2538     2539    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...he/shardingsphere/infra/hint/SQLHintTokenEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/23189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRUb2tlbkVudW0uamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/23189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `81.13% <0.00%> (+1.13%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org