You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/18 16:30:40 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3799: ARTEMIS-3363 Fix TransportConfiguration extraProps encoding

clebertsuconic commented on a change in pull request #3799:
URL: https://github.com/apache/activemq-artemis/pull/3799#discussion_r731112387



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/TransportConfiguration.java
##########
@@ -46,6 +48,8 @@
 
    private static final long serialVersionUID = -3994528421527392679L;
 
+   public static final String EXTRA_PROPERTY_PREFIX = ActiveMQDefaultConfiguration.DEFAULT_INTERNAL_NAMING_PREFIX + "extra.property.";

Review comment:
       - make it private static final
   - Make it very short... 
   
   ```
    private static final String EXTRA_PROPERTY_PREFIX = "ep.";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org