Re: [PR] Add additional benchmarks for utf8view comparison kernels [arrow-rs]

["zhuqi-lucas (via GitHub)" <gi...@apache.org>]

zhuqi-lucas commented on PR #7351:
URL: https://github.com/apache/arrow-rs/pull/7351#issuecomment-2763063499

   > Thank you @zhuqi-lucas --- this looks great. I can't wait to see the performance improvements.
   > 
   > I left some style comments. My biggest suggestion for this PR is to follow the pattern of the rest of the benchmarks in this function which are organized by operation rather than by data type I think
   > 
   > So for example, put the new `like` tests with longer strings next to the existing `like` tests in
   > 
   > https://github.com/apache/arrow-rs/blob/a2cc42639b4ad5579d052e6f2317a413e2407e0f/arrow/benches/comparison_kernels.rs#L228-L232
   
   Thank you @alamb for review, it makes sense to keep the original format for new benchmark, i will address the comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org