[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5863: [TIR][REFACTOR][API-CHANGE] Change Call.name to Call.op(RelayExpr)

[GitBox <gi...@apache.org>]

junrushao1994 commented on a change in pull request #5863:
URL: https://github.com/apache/incubator-tvm/pull/5863#discussion_r443801629



##########
File path: include/tvm/tir/expr.h
##########
@@ -888,66 +888,43 @@ class CallNode : public PrimExprNode {
     /*! \brief Intrinsic functions that are pure. */
     PureIntrinsic = 5
   };
-  /*! \brief The name of the function/intrinsic. */
-  String name;
+  /*!
+   * \brief The operator(function) being invoked
+   *
+   *  - It can be tvm::Op which corresponds to the primitive operators(intrinsics).
+   *  - It can also be another function in the IRModule (GlobalVar).
+   */
+  RelayExpr op;

Review comment:
       Do you think we should someday move GlobalVar out of RelayExpr?

##########
File path: include/tvm/tir/op_attr_types.h
##########
@@ -0,0 +1,48 @@
+/*

Review comment:
       Shall we migrate relay/op_attr_types into this file too?

##########
File path: python/tvm/contrib/nvcc.py
##########
@@ -98,7 +98,8 @@ def compile_cuda(code,
     (out, _) = proc.communicate()
 
     if proc.returncode != 0:
-        msg = "Compilation error:\n"
+        msg = code

Review comment:
       Is this intended change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org