You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/12/28 21:46:38 UTC
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/20105
[SPARK-22920][SPARKR] sql functions for current_date, current_timestamp, rtrim/ltrim/trim with trimString
## What changes were proposed in this pull request?
Add sql functions
## How was this patch tested?
manual, unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rsqlfuncs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20105
----
commit c8e118a4c6e0f9f05d3c48c3d715da82b4ebd334
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T11:11:41Z
ltrim/rtrim/trim with trimString + current_date() + current_timestamp()
commit 284c74a7e74fb24024cf4cc6557b30e1169cf445
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T11:12:18Z
NeedsCompilation in DESCRIPTION
commit 1f2fac3afc376fd61e54cb12b6c34f60f5522280
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T21:44:29Z
fix example
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20105: [SPARK-22920][SPARKR] sql functions for current_date, cu...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20105
thanks!
merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20105: [SPARK-22920][SPARKR] sql functions for current_date, cu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85480/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
Posted by felixcheung <gi...@git.apache.org>.
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/20105
[SPARK-22920][SPARKR] sql functions for current_date, current_timestamp, rtrim/ltrim/trim with trimString
## What changes were proposed in this pull request?
Add sql functions
## How was this patch tested?
manual, unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rsqlfuncs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20105
----
commit c8e118a4c6e0f9f05d3c48c3d715da82b4ebd334
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T11:11:41Z
ltrim/rtrim/trim with trimString + current_date() + current_timestamp()
commit 284c74a7e74fb24024cf4cc6557b30e1169cf445
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T11:12:18Z
NeedsCompilation in DESCRIPTION
commit 1f2fac3afc376fd61e54cb12b6c34f60f5522280
Author: Felix Cheung <fe...@...>
Date: 2017-12-28T21:44:29Z
fix example
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20105: [SPARK-22920][SPARKR] sql functions for current_date, cu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20105
**[Test build #85480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85480/testReport)** for PR 20105 at commit [`1f2fac3`](https://github.com/apache/spark/commit/1f2fac3afc376fd61e54cb12b6c34f60f5522280).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20105#discussion_r159002780
--- Diff: R/pkg/DESCRIPTION ---
@@ -59,3 +59,4 @@ Collate:
'window.R'
RoxygenNote: 5.0.1
VignetteBuilder: knitr
+NeedsCompilation: no
--- End diff --
this gets flagged from CRAN when submitted
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/20105
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20105: [SPARK-22920][SPARKR] sql functions for current_date, cu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20105
**[Test build #85480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85480/testReport)** for PR 20105 at commit [`1f2fac3`](https://github.com/apache/spark/commit/1f2fac3afc376fd61e54cb12b6c34f60f5522280).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20105
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20105: [SPARK-22920][SPARKR] sql functions for current_d...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20105#discussion_r159002733
--- Diff: R/pkg/R/functions.R ---
@@ -2777,11 +2815,11 @@ setMethod("rpad", signature(x = "Column", len = "numeric", pad = "character"),
})
#' @details
-#' \code{substring_index}: Returns the substring from string str before count occurrences of
-#' the delimiter delim. If count is positive, everything the left of the final delimiter
-#' (counting from left) is returned. If count is negative, every to the right of the final
-#' delimiter (counting from the right) is returned. substring_index performs a case-sensitive
-#' match when searching for delim.
+#' \code{substring_index}: Returns the substring from string (\code{x}) before \code{count}
--- End diff --
this is mainly to fix the reference to `str` which doesn't exist here
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20105: [SPARK-22920][SPARKR] sql functions for current_date, cu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20105
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org