You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Igor Kryvenko <kr...@gmail.com> on 2018/03/20 14:15:28 UTC

Re: Review Request 65992: HIVE-18727: Update GenericUDFEnforceNotNullConstraint to throw an ERROR instead of Exception on failure

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65992/
-----------------------------------------------------------

(Updated Март 20, 2018, 2:15 п.п.)


Review request for hive and Vineet Garg.


Repository: hive-git


Description
-------

Throwing an exception makes TezProcessor stop retrying the task. Since this is NOT NULL constraint violation we don't want TezProcessor to keep retrying on failure.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/errors/DataConstraintViolationError.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java e8516fb8e0637be625258ac27f3a0615a357ab21 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFEnforceNotNullConstraint.java PRE-CREATION 


Diff: https://reviews.apache.org/r/65992/diff/2/

Changes: https://reviews.apache.org/r/65992/diff/1-2/


Testing
-------


Thanks,

Igor Kryvenko