You are viewing a plain text version of this content. The canonical link for it is here.
Posted to photark-dev@incubator.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2010/05/15 07:23:42 UTC
[jira] Created: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
---------------------------------------------------------------------------------------------------
Key: PHOTARK-41
URL: https://issues.apache.org/jira/browse/PHOTARK-41
Project: PhotArk
Issue Type: Bug
Components: PhotArk UI
Affects Versions: PhotArk M2
Reporter: Henry Saputra
Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html
and meta content type, also do fix missing images from upload.css
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867828#action_12867828 ]
Henry Saputra commented on PHOTARK-41:
--------------------------------------
Code review is in
http://codereview.appspot.com/1238041/show
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra reopened PHOTARK-41:
----------------------------------
The patch does not move the png file to new images directory under photark-ui-admin/src/main/webapp/admin.
These steps need to be done:
pushd photark-ui-admin/src/main/webapp/admin
svn mkdir images
svn mv *.png images
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Fix For: PhotArk M3
>
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated PHOTARK-41:
---------------------------------
Attachment: doctype.patch
Patch for this jira
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende resolved PHOTARK-41.
------------------------------------
Resolution: Fixed
Patch applied. Thanks Henry.
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Fix For: PhotArk M3
>
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html
and meta content type, also do fix missing images from upload.css
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867837#action_12867837 ]
Henry Saputra commented on PHOTARK-41:
--------------------------------------
Luciano,
Apparently the patch that I attached before was not complete. Svn diff couldnt show me moving the png files to new images directory in
photark-ui-admin/src/main/webapp/admin
the complete fix should do this:
pushd photark-ui-admin/src/main/webapp/admin
svn mkdir images
svn mv *.png images
This will move the png files for admin to images directory so it could be accessed from the css.
I apologize for the trouble.
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Fix For: PhotArk M3
>
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende updated PHOTARK-41:
-----------------------------------
Fix Version/s: PhotArk M3
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Fix For: PhotArk M3
>
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PHOTARK-41) Add HTML5 DOCTYPE to gallery.html and
meta content type, also do fix missing images from upload.css
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende resolved PHOTARK-41.
------------------------------------
Resolution: Fixed
Additional changes committed. Thanks Henry.
> Add HTML5 DOCTYPE to gallery.html and meta content type, also do fix missing images from upload.css
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOTARK-41
> URL: https://issues.apache.org/jira/browse/PHOTARK-41
> Project: PhotArk
> Issue Type: Bug
> Components: PhotArk UI
> Affects Versions: PhotArk M2
> Reporter: Henry Saputra
> Fix For: PhotArk M3
>
> Attachments: doctype.patch
>
>
> Add HTML5 DOCTYPE to gallery.html to avoid browser quirk mode and change DOCTYPE in upload.html to use HTML5 DOCTYPE.
> All modern browsers should be able to look for standard mode even though its not implementing HTML5 yet.
> Fix missing reference to images in upload.css file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.