You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/10/31 16:39:07 UTC

[GitHub] spark pull request #22894: [SPARK-25885][Core][Minor] HighlyCompressedMapSta...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22894#discussion_r229774707
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -189,13 +190,12 @@ private[spark] class HighlyCompressedMapStatus private (
         emptyBlocks.readExternal(in)
         avgSize = in.readLong()
         val count = in.readInt()
    -    val hugeBlockSizesArray = mutable.ArrayBuffer[Tuple2[Int, Byte]]()
    +    hugeBlockSizes = new util.HashMap[Int, Byte](count).asScala
    --- End diff --
    
    we should use a `mutable.Map` instead of the java implementation wrapped by scala, this is not a clean solution IMHO


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org