You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/06 10:59:33 UTC
[GitHub] [maven] cstamas opened a new pull request #652: Proposal to change abstract provider
cstamas opened a new pull request #652:
URL: https://github.com/apache/maven/pull/652
Proposed changes for https://github.com/apache/maven/pull/651:
* validate input
* do not modify loop invariant within loop body
Remarks:
* IF we allow "null" life-cycles then modify validation from `if ( len < 1 || len % 2 != 0 )` to `if ( len % 2 != 0 )`
* IF we do NOT allow "null" life-cycles, then modify validation from `if ( len < 1 || len % 2 != 0 )` to `if ( len < 2 || len % 2 != 0 )`
(and in both cases adjust exception message as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #652: Proposal to change abstract provider
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #652:
URL: https://github.com/apache/maven/pull/652#issuecomment-1006775384
nice improvements, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit merged pull request #652: Proposal to change abstract provider
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #652:
URL: https://github.com/apache/maven/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org