You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/05 01:31:40 UTC

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #519: [IOTDB-257] makes the client stop fetch when dataSize equals maxPrintRowCount and change client fetchSize less than maxPrintRowCount

liutaohua commented on a change in pull request #519: [IOTDB-257] makes the client stop fetch when dataSize equals maxPrintRowCount and change client fetchSize less than maxPrintRowCount
URL: https://github.com/apache/incubator-iotdb/pull/519#discussion_r342348941
 
 

 ##########
 File path: client/src/main/java/org/apache/iotdb/client/AbstractClient.java
 ##########
 @@ -221,6 +221,7 @@ private static void output(ResultSet res, boolean printToConsole, ZoneId zoneId)
       }
       if (displayCnt == maxPrintRowCount) {
         println(String.format("Reach maxPrintRowCount = %s lines", maxPrintRowCount));
+        return;
 
 Review comment:
   I don't agree you,  because data still exists in `res.next()` , we just stopped getting data because we reached the `maxPrintRowCount `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services