You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 18:15:07 UTC

[GitHub] [airflow] tonycoco opened a new issue #13495: Operator will fail if listing reports exceed quotas on Campaign Manager 360 API

tonycoco opened a new issue #13495:
URL: https://github.com/apache/airflow/issues/13495


   **Apache Airflow version**: latest
   
   **Environment**:
   
   Google Cloud – Composer
   
   **What happened**:
   
   From `airflow.providers.google.marketing_platform.operators.campaign_manager` see: `GoogleCampaignManagerDeleteReportOperator`
   
   https://github.com/apache/airflow/blob/master/airflow/providers/google/marketing_platform/operators/campaign_manager.py#L114
   
   When using a `report_name` to delete the report (not an ID) this list command will cause quota to be exceeded if the report's name is pages down the list and if you have many copies of this operator running concurrently.
   
   **What you expected to happen**:
   
   Delete the report just fine.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #13495: Operator will fail if listing reports exceed quotas on Campaign Manager 360 API

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #13495:
URL: https://github.com/apache/airflow/issues/13495


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #13495: Operator will fail if listing reports exceed quotas on Campaign Manager 360 API

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13495:
URL: https://github.com/apache/airflow/issues/13495#issuecomment-754828138


   And just to add to it. The root cause of the problem is that the API of campaign manager does not have any other way to get the report by name https://developers.google.com/doubleclick-advertisers/v3.3/reports/get only can use Id, and https://developers.google.com/doubleclick-advertisers/v3.3/reports/list does not allow filtering by name. 
   
   The only way to optimize the "by name" search is to ask the campaign manager team to improve their API. So you should rather open an issue to the campaign manager API rather than to the operator, as we are simply using the API that is available.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #13495: Operator will fail if listing reports exceed quotas on Campaign Manager 360 API

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13495:
URL: https://github.com/apache/airflow/issues/13495#issuecomment-754808657


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org