You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/22 22:08:53 UTC
[GitHub] [incubator-pinot] jihaozh opened a new pull request #5733: [TE] deprecate the yaml/list endpoint
jihaozh opened a new pull request #5733:
URL: https://github.com/apache/incubator-pinot/pull/5733
This PR marks the "yaml/list" endpoint as deprecated because it is not scalable. The new endpoint '/alerts' has been built to search the alerts more efficiently. Also, this PR limits the query to 100 alerts at most to avoid possible out of memory issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5733: [TE] deprecate the yaml/list endpoint
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5733:
URL: https://github.com/apache/incubator-pinot/pull/5733#discussion_r459114172
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -1067,14 +1067,14 @@ private boolean filterConfigsBy(Map<String, Object> detectionConfig, String data
List<Map<String, Object>> yamls;
if (dataset == null && metric == null) {
yamls = this.detectionConfigDAO
- .findAll()
+ .list(100, 0)
Review comment:
can you update the java-doc of this helper method as well!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5733: [TE] deprecate the yaml/list endpoint
Posted by GitBox <gi...@apache.org>.
jihaozh commented on a change in pull request #5733:
URL: https://github.com/apache/incubator-pinot/pull/5733#discussion_r459119863
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -1067,14 +1067,14 @@ private boolean filterConfigsBy(Map<String, Object> detectionConfig, String data
List<Map<String, Object>> yamls;
if (dataset == null && metric == null) {
yamls = this.detectionConfigDAO
- .findAll()
+ .list(100, 0)
Review comment:
Thanks. updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #5733: [TE] deprecate the yaml/list endpoint
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #5733:
URL: https://github.com/apache/incubator-pinot/pull/5733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org