You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/25 07:17:00 UTC
[GitHub] [servicecomb-kie] GuoYL123 opened a new pull request #125: fix
status/value_type don't update
GuoYL123 opened a new pull request #125: fix status/value_type don't update
URL: https://github.com/apache/servicecomb-kie/pull/125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #125: fix
status don't update
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #125: fix status don't update
URL: https://github.com/apache/servicecomb-kie/pull/125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #125: fix status don't update
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #125: fix status don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397713434
##########
File path: server/resource/v1/history_resource_test.go
##########
@@ -90,8 +90,8 @@ func TestHistoryResource_GetPollingData(t *testing.T) {
t.Run("list kv by service label, to create a polling data", func(t *testing.T) {
r, _ := http.NewRequest("GET", "/v1/test/kie/kv", nil)
noopH := &handler2.NoopAuthHandler{}
- noopH2 := &handler2.TrackHandler{}
Review comment:
noop 的意思是no operation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #125: fix status don't update
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #125: fix status don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397713980
##########
File path: server/resource/v1/history_resource_test.go
##########
@@ -90,8 +90,8 @@ func TestHistoryResource_GetPollingData(t *testing.T) {
t.Run("list kv by service label, to create a polling data", func(t *testing.T) {
r, _ := http.NewRequest("GET", "/v1/test/kie/kv", nil)
noopH := &handler2.NoopAuthHandler{}
- noopH2 := &handler2.TrackHandler{}
Review comment:
还是改下吧，1,2这种命名也是很奇怪的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #125: fix status/value_type don't update
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397674245
##########
File path: server/service/mongo/kv/kv_dao.go
##########
@@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+ {"value_type", kv.ValueType},
Review comment:
我担心引入复杂性，类型这种东西以后我们要基于它做什么演进特性就麻烦了，我只想减少复杂度引起的思考
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #125: fix status/value_type don't update
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397651742
##########
File path: server/service/mongo/kv/kv_dao.go
##########
@@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+ {"value_type", kv.ValueType},
Review comment:
value_type 本来就不支持修改
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#125: fix status/value_type don't update
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #125: fix status/value_type don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397654299
##########
File path: server/service/mongo/kv/kv_dao.go
##########
@@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+ {"value_type", kv.ValueType},
Review comment:
感觉可以前台控制，后台保留能力
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#125: fix status don't update
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #125: fix status don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r398260063
##########
File path: server/resource/v1/history_resource_test.go
##########
@@ -90,8 +90,8 @@ func TestHistoryResource_GetPollingData(t *testing.T) {
t.Run("list kv by service label, to create a polling data", func(t *testing.T) {
r, _ := http.NewRequest("GET", "/v1/test/kie/kv", nil)
noopH := &handler2.NoopAuthHandler{}
- noopH2 := &handler2.TrackHandler{}
Review comment:
这是删掉的代码，新增的已经修改了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] GuoYL123 commented on a change in pull request
#125: fix status don't update
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #125: fix status don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397681357
##########
File path: server/service/mongo/kv/kv_dao.go
##########
@@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error {
ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{
{"$set", bson.D{
{"value", kv.Value},
+ {"value_type", kv.ValueType},
Review comment:
取消了value_type的更新
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services