You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Bing Li <sm...@aliyun.com> on 2015/12/10 07:16:15 UTC

Review Request 41191: AMBARI-14317: Hive service check with Beeline should not pass in ssl settings if SSL is disabled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41191/
-----------------------------------------------------------

Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-14317
    https://issues.apache.org/jira/browse/AMBARI-14317


Repository: ambari


Description
-------

In Services -> Hive -> Configs,
1. disable SSL
2. add the properties for ssl keystore in hive-site.xml
hive.server2.keystore.path
hive.server2.keystore.password
3. save the configuration, and restart hive services
Then I can get an alert from HiveServer2, go to the details I found that
the beeline tried to connect HS2 with "ssl=true;sslTrustStore=/path/trust_store.jks;trustStorePassword=xyz", which is NOT correct.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd 

Diff: https://reviews.apache.org/r/41191/diff/


Testing
-------

I have verified it in my local cluster.


Thanks,

Bing Li


Re: Review Request 41191: AMBARI-14317: Hive service check with Beeline should not pass in ssl settings if SSL is disabled

Posted by Bing Li <sm...@aliyun.com>.

> On Dec. 14, 2015, 7:15 a.m., Alejandro Fernandez wrote:
> > Ship It!

Hi, Alejandro
Thank you for your review.
Since I'm not the committer of Ambari, could you help to merge this change to trunk branch? 
Thank you.


- Bing


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41191/#review110173
-----------------------------------------------------------


On Jan. 5, 2016, 2:33 p.m., Bing Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41191/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:33 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-14317
>     https://issues.apache.org/jira/browse/AMBARI-14317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Services -> Hive -> Configs,
> 1. disable SSL
> 2. add the properties for ssl keystore in hive-site.xml
> hive.server2.keystore.path
> hive.server2.keystore.password
> 3. save the configuration, and restart hive services
> Then I can get an alert from HiveServer2, go to the details I found that
> the beeline tried to connect HS2 with "ssl=true;sslTrustStore=/path/trust_store.jks;trustStorePassword=xyz", which is NOT correct.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd 
> 
> Diff: https://reviews.apache.org/r/41191/diff/
> 
> 
> Testing
> -------
> 
> I have verified it in my local cluster.
> 
> 
> Thanks,
> 
> Bing Li
> 
>


Re: Review Request 41191: AMBARI-14317: Hive service check with Beeline should not pass in ssl settings if SSL is disabled

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41191/#review110173
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Dec. 14, 2015, 7:13 a.m., Bing Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41191/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 7:13 a.m.)
> 
> 
> Review request for Ambari and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14317
>     https://issues.apache.org/jira/browse/AMBARI-14317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Services -> Hive -> Configs,
> 1. disable SSL
> 2. add the properties for ssl keystore in hive-site.xml
> hive.server2.keystore.path
> hive.server2.keystore.password
> 3. save the configuration, and restart hive services
> Then I can get an alert from HiveServer2, go to the details I found that
> the beeline tried to connect HS2 with "ssl=true;sslTrustStore=/path/trust_store.jks;trustStorePassword=xyz", which is NOT correct.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd 
> 
> Diff: https://reviews.apache.org/r/41191/diff/
> 
> 
> Testing
> -------
> 
> I have verified it in my local cluster.
> 
> 
> Thanks,
> 
> Bing Li
> 
>


Re: Review Request 41191: AMBARI-14317: Hive service check with Beeline should not pass in ssl settings if SSL is disabled

Posted by Bing Li <sm...@aliyun.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41191/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 7:13 a.m.)


Review request for Ambari and Yusaku Sako.


Bugs: AMBARI-14317
    https://issues.apache.org/jira/browse/AMBARI-14317


Repository: ambari


Description
-------

In Services -> Hive -> Configs,
1. disable SSL
2. add the properties for ssl keystore in hive-site.xml
hive.server2.keystore.path
hive.server2.keystore.password
3. save the configuration, and restart hive services
Then I can get an alert from HiveServer2, go to the details I found that
the beeline tried to connect HS2 with "ssl=true;sslTrustStore=/path/trust_store.jks;trustStorePassword=xyz", which is NOT correct.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd 

Diff: https://reviews.apache.org/r/41191/diff/


Testing
-------

I have verified it in my local cluster.


Thanks,

Bing Li