[GitHub] [airflow] mik-laj commented on a change in pull request #13058: Set timeout for child processes

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #13058:
URL: https://github.com/apache/airflow/pull/13058#discussion_r542373341



##########
File path: airflow/configuration.py
##########
@@ -69,7 +69,9 @@ def run_command(command):
     process = subprocess.Popen(
         shlex.split(command), stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True
     )
-    output, stderr = [stream.decode(sys.getdefaultencoding(), 'ignore') for stream in process.communicate()]
+    output, stderr = [
+        stream.decode(sys.getdefaultencoding(), 'ignore') for stream in process.communicate(timeout=60)

Review comment:
       This value is much greater than the time it takes to complete this process. It seems to me that processes that take longer than 5 seconds will not be started here as this would have an impact on the environment performance.  I am not trying to solve the problems that processes are freezing and we should handle these situations somehow, but for now I just want the user to be notified that the process has stopped responding. In the future, we might think of a better way to handle it once these problems are reported along with the use case.
   
   What do you think about increasing this time to 5 minutes? Is this a more rational time for you?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org