You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/19 08:41:00 UTC

[jira] [Commented] (CAMEL-11144) camel-milo - Use dynamic port in test

    [ https://issues.apache.org/jira/browse/CAMEL-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092794#comment-16092794 ] 

ASF GitHub Bot commented on CAMEL-11144:
----------------------------------------

GitHub user ctron opened a pull request:

    https://github.com/apache/camel/pull/1834

    CAMEL-11144: Make the unit tests use dynamic ports

    The unit tests for camel-milo currently use static ports, this change
    implements the use of dynamic ports.
    
    This change depends on the fix of CAMEL-11559
    
    Signed-off-by: Jens Reimann <jr...@redhat.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ctron/camel feature/fix_issue_11144_1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1834
    
----
commit a335df0897b5c474fd6a4691678735f7fc9e2f74
Author: Jens Reimann <jr...@redhat.com>
Date:   2017-07-19T08:23:49Z

    CAMEL-11144: Make the unit tests use dynamic ports
    
    The unit tests for camel-milo currently use static ports, this change
    implements the use of dynamic ports.
    
    This change depends on the fix of CAMEL-11559
    
    Signed-off-by: Jens Reimann <jr...@redhat.com>

----


> camel-milo - Use dynamic port in test
> -------------------------------------
>
>                 Key: CAMEL-11144
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11144
>             Project: Camel
>          Issue Type: Test
>            Reporter: Claus Ibsen
>            Assignee: Jens Reimann
>             Fix For: 2.20.0
>
>
> This component uses hard coded port numbers which should be dynamic assigned so it tests better on CI servers etc.
> Also the tests must be improved as they tend to hang etc.
> And the test code should be polished and updated as it has a bunch of commented out stuff and seems personal hostnames etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)