You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/28 19:01:33 UTC

[GitHub] [beam] benWize commented on a change in pull request #16200: [BEAM-11808][BEAM-9879] Support aggregate functions with two arguments

benWize commented on a change in pull request #16200:
URL: https://github.com/apache/beam/pull/16200#discussion_r776036947



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/udaf/StringAgg.java
##########
@@ -73,4 +79,53 @@ public String extractOutput(String output) {
       return output;
     }
   }
+
+  /** A {@link CombineFn} that aggregates bytes with a byte as delimiter. */

Review comment:
       Changed it!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org