You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "chenjunjiedada (via GitHub)" <gi...@apache.org> on 2023/05/22 12:04:12 UTC

[GitHub] [iceberg] chenjunjiedada commented on a diff in pull request #7628: Flink 1.17: Support alter table column

chenjunjiedada commented on code in PR #7628:
URL: https://github.com/apache/iceberg/pull/7628#discussion_r1200421450


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -472,11 +479,13 @@ public void alterTable(ObjectPath tablePath, CatalogBaseTable newTable, boolean
 
     CatalogTable table = toCatalogTable(icebergTable);
 
-    // Currently, Flink SQL only support altering table properties.
+    // This alterTable API only supports altering table properties.

Review Comment:
   Should we deprecate this API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org