[GitHub] [spark] juliuszsompolski commented on a change in pull request #25277: [WIP] Thriftserver support interval type

[GitBox <gi...@apache.org>]

juliuszsompolski commented on a change in pull request #25277: [WIP] Thriftserver support interval type
URL: https://github.com/apache/spark/pull/25277#discussion_r308590472
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ##########
 @@ -308,7 +311,11 @@ private[hive] class SparkExecuteStatementOperation(
 object SparkExecuteStatementOperation {
   def getTableSchema(structType: StructType): TableSchema = {
     val schema = structType.map { field =>
-      val attrTypeString = if (field.dataType == NullType) "void" else field.dataType.catalogString
+      val attrTypeString = field.dataType match {
+        case NullType => "void"
+        case CalendarIntervalType => "string"
 
 Review comment:
   Hm. So we have thriftserver v1.2.1 imported, but don't have that patch released in v1.2.0?
   Does it work with the v2.3.5 thriftserver?
   It seems we indeed could import that HIVE patch instead of converting to string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org