You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/29 20:29:02 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10414: MINOR: Self-managed -> Kraft (Kafka Raft)

ijuma commented on a change in pull request #10414:
URL: https://github.com/apache/kafka/pull/10414#discussion_r603591568



##########
File path: raft/bin/test-kraft-server-start.sh
##########
@@ -17,7 +17,7 @@
 base_dir=$(dirname $0)
 
 if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
-    export KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/raft-log4j.properties"
+    export KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/kraft-log4j.properties"

Review comment:
       @jsancio The folder names for the modules don't `kafka` even though the published artifacts do (`clients` and `kafka-clients`). The artifact for the `raft` module is `kafka-raft` and it was originally released in 2.7. I don't want to change that right now. Similarly, for the package names, since they're `kafka.raft`, I think we can leave it like that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org