You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/05 14:55:00 UTC
[jira] [Commented] (IMPALA-8907) TestResultSpooling.test_slow_query
is flaky
[ https://issues.apache.org/jira/browse/IMPALA-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923505#comment-16923505 ]
ASF subversion and git services commented on IMPALA-8907:
---------------------------------------------------------
Commit 1915a3e7f49f753cf18b919a087e249fe6769127 in impala's branch refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1915a3e ]
IMPALA-8907: TestResultSpooling.test_slow_query is flaky
De-flake test_result_spooling.py::TestResultsSpooling::test_slow_query
by increasing the delay in RowBatch production. This patch makes two
fixes to ensure that RowBatchGetWaitTime is a non-zero value:
* Add the DELAY DEBUG_ACTION to the SCAN_NODE rather than the
EXCHANGE_NODE. Since the EXCHANGE_NODE only processes a few rows, adding
the delay to the SCAN_NODE decreases the rate at which results are
produced.
* Wait for all rows to be fetched before checking if RowBatchGetWaitTime
is in the profile. This fixes a possible race condition where the fetch
thread was not able to issue the fetch RPC before the test checked if
RowBatchGetWaitTime was in the runtime profile.
Testing:
* Looped test_slow_query for several hours with 0 failures
Change-Id: Idcb4a6b38f85a9497f80e2674e1c1fa512be5940
Reviewed-on: http://gerrit.cloudera.org:8080/14170
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> TestResultSpooling.test_slow_query is flaky
> -------------------------------------------
>
> Key: IMPALA-8907
> URL: https://issues.apache.org/jira/browse/IMPALA-8907
> Project: IMPALA
> Issue Type: Bug
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Priority: Major
>
> Recently failed in an ubuntu-16.04-dockerised-tests job: [https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/1102/testReport/junit/query_test.test_result_spooling/TestResultSpooling/test_slow_query_protocol__beeswax___exec_option____batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__parquet_none_/]
> Error Message:
> {code:java}
> query_test/test_result_spooling.py:172: in test_slow_query assert re.search(get_wait_time_regex, self.client.get_runtime_profile(handle)) \ E assert None is not None E + where None = <function search at 0x7f0da4115c08>('RowBatchGetWaitTime: [1-9]', 'Query (id=7f47e1d6a1a1c804:492214eb00000000):\n DEBUG MODE WARNING: Query profile created while running a DEBUG buil... - OptimizationTime: 331.998ms\n - PeakMemoryUsage: 1.09 MB (1144320)\n - PrepareTime: 31.999ms\n') E + where <function search at 0x7f0da4115c08> = re.search E + and 'Query (id=7f47e1d6a1a1c804:492214eb00000000):\n DEBUG MODE WARNING: Query profile created while running a DEBUG buil... - OptimizationTime: 331.998ms\n - PeakMemoryUsage: 1.09 MB (1144320)\n - PrepareTime: 31.999ms\n' = <bound method BeeswaxConnection.get_runtime_profile of <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>>(<tests.common.impala_connection.OperationHandle object at 0x7f0d94afffd0>) E + where <bound method BeeswaxConnection.get_runtime_profile of <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>> = <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>.get_runtime_profile E + where <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0> = <test_result_spooling.TestResultSpooling object at 0x7f0d94af3d50>.client {code}
> Stacktrace:
> {code:java}
> query_test/test_result_spooling.py:172: in test_slow_query
> assert re.search(get_wait_time_regex, self.client.get_runtime_profile(handle)) \
> E assert None is not None
> E + where None = <function search at 0x7f0da4115c08>('RowBatchGetWaitTime: [1-9]', 'Query (id=7f47e1d6a1a1c804:492214eb00000000):\n DEBUG MODE WARNING: Query profile created while running a DEBUG buil... - OptimizationTime: 331.998ms\n - PeakMemoryUsage: 1.09 MB (1144320)\n - PrepareTime: 31.999ms\n')
> E + where <function search at 0x7f0da4115c08> = re.search
> E + and 'Query (id=7f47e1d6a1a1c804:492214eb00000000):\n DEBUG MODE WARNING: Query profile created while running a DEBUG buil... - OptimizationTime: 331.998ms\n - PeakMemoryUsage: 1.09 MB (1144320)\n - PrepareTime: 31.999ms\n' = <bound method BeeswaxConnection.get_runtime_profile of <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>>(<tests.common.impala_connection.OperationHandle object at 0x7f0d94afffd0>)
> E + where <bound method BeeswaxConnection.get_runtime_profile of <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>> = <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0>.get_runtime_profile
> E + where <tests.common.impala_connection.BeeswaxConnection object at 0x7f0d94afa7d0> = <test_result_spooling.TestResultSpooling object at 0x7f0d94af3d50>.client {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org