You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ryan Hennig (JIRA)" <ji...@apache.org> on 2012/07/19 16:12:35 UTC
[jira] [Created] (MAPREDUCE-4462) Add comments to
TestFairScheduler.java
Ryan Hennig created MAPREDUCE-4462:
--------------------------------------
Summary: Add comments to TestFairScheduler.java
Key: MAPREDUCE-4462
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: scheduler, test
Reporter: Ryan Hennig
Priority: Minor
Fix For: 2.1.0-alpha
While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly. Creating a JIRA as a placeholder to submit this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4462) Enhance readability of
TestFairScheduler.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-4462:
-------------------------------------
Fix Version/s: (was: 2.0.2-alpha)
2.0.3-alpha
> Enhance readability of TestFairScheduler.java
> ---------------------------------------------
>
> Key: MAPREDUCE-4462
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler, test
> Reporter: Ryan Hennig
> Priority: Minor
> Labels: comments, test
> Fix For: 2.0.3-alpha
>
> Attachments: MAPREDUCE-4462.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4462) Add comments to
TestFairScheduler.java
Posted by "Ryan Hennig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419437#comment-13419437 ]
Ryan Hennig commented on MAPREDUCE-4462:
----------------------------------------
When I was browsing this code on the ipad, I did not have tools to jump around the code and I misinterpreted the units as MB, since the setResources(int memory) call had no comments to specify the measurement unit. I saw that the other scheduler test code makes widespread use of this "* GB" construct, so I adopted it for use in the Fair Scheduler code.
> Add comments to TestFairScheduler.java
> --------------------------------------
>
> Key: MAPREDUCE-4462
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler, test
> Reporter: Ryan Hennig
> Priority: Minor
> Labels: comments, test
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE-4462.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly. Creating a JIRA as a placeholder to submit this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4462) Enhance readability of
TestFairScheduler.java
Posted by "Ryan Hennig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Hennig updated MAPREDUCE-4462:
-----------------------------------
Description:
While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly.
was:While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly. Creating a JIRA as a placeholder to submit this work.
Remaining Estimate: 2h (was: 48h)
Original Estimate: 2h (was: 48h)
Summary: Enhance readability of TestFairScheduler.java (was: Add comments to TestFairScheduler.java)
> Enhance readability of TestFairScheduler.java
> ---------------------------------------------
>
> Key: MAPREDUCE-4462
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler, test
> Reporter: Ryan Hennig
> Priority: Minor
> Labels: comments, test
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE-4462.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4462) Add comments to
TestFairScheduler.java
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419390#comment-13419390 ]
Mayank Bansal commented on MAPREDUCE-4462:
------------------------------------------
I think documentation in code is enough for explaining 1024 => GB, I don't think this patch is required, may be if we just add documentation is enough. That is just my point of view.
Thanks,
Mayank
> Add comments to TestFairScheduler.java
> --------------------------------------
>
> Key: MAPREDUCE-4462
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler, test
> Reporter: Ryan Hennig
> Priority: Minor
> Labels: comments, test
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE-4462.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly. Creating a JIRA as a placeholder to submit this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4462) Add comments to
TestFairScheduler.java
Posted by "Ryan Hennig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Hennig updated MAPREDUCE-4462:
-----------------------------------
Attachment: MAPREDUCE-4462.patch
This patch contains both comments added to the various test cases, and changing asserts which use literals like "2048" to use "2 * GB" instead so that the units are not as easily confused by readers
> Add comments to TestFairScheduler.java
> --------------------------------------
>
> Key: MAPREDUCE-4462
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler, test
> Reporter: Ryan Hennig
> Priority: Minor
> Labels: comments, test
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE-4462.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> While reading over the unit tests for the Fair Scheduler introduced by MAPREDUCE-3451, I added comments to make the logic of the test easier to grok quickly. Creating a JIRA as a placeholder to submit this work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira