You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nolanlawson <gi...@git.apache.org> on 2017/02/18 16:03:15 UTC
[GitHub] couchdb-fauxton pull request #854: don't encode username/pass unless necessa...
GitHub user nolanlawson opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/854
don't encode username/pass unless necessary
This along with https://github.com/pouchdb/pouchdb-server/pull/170 should fix https://github.com/pouchdb/express-pouchdb/issues/430.
The goal is just to avoid encoding the username/password if we're in admin party mode and neither is required. This avoids the `http://null:@localhost` bug.
Unfortunately this doesn't 100% fix the problem, because it relies on the URL of fauxton being the same as the URL of the CouchDB itself, which is not always the case. But it'll at least fix things for pouchdb-server as-is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nolanlawson/couchdb-fauxton express-pouchdb-430
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #854
----
commit d98cefc2cba10b9d408e70b9ebdb89318c2bad99
Author: Nolan Lawson <no...@gmail.com>
Date: 2017-02-18T16:01:31Z
don't encode username/pass unless necessary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/854
okay, closing in favor of https://github.com/apache/couchdb-fauxton/pull/858
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/854
@nolanlawson I've added a test and continued this work here https://github.com/apache/couchdb-fauxton/pull/858
If the tests all pass I'll merge it all in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/854
One thing I was very confused about with this code is that, to replicate to or from local DBs, you don't need to specify the full URL; you can just specify the DB name. E.g.:
```bash
curl -X POST http://localhost:6984/_replicator \
-H 'content-type:application/json' \
-d '{"_id": "test_replication1", "source": "http://examples.cloudant.com/animaldb", "target": "animaldb", "create_target": true}'
```
This works fine; is there any reason to use the full URL for local DBs? It also breaks when you run Fauxton at a different root than the database itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/854
One thing, we need full urls because CouchDB 2.0 requires it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #854: don't encode username/pass unless necessa...
Posted by nolanlawson <gi...@git.apache.org>.
Github user nolanlawson closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---